Fix list view drop direction updates #415
Conversation
In #setDropMenuLocation, the bounding rectangle for the menu was being calculated before it was rendered causing the height to be 0. For some reason the $timeout was not waiting for the digest cycle to complete, however, adding a 100 ms delay consistently drops the menu in the proper direction. Fixes patternfly#399
|
Rather than using a timeout to "hopefully" get the timing correct, is there another event we can be listening for to ensure the rendering is complete before calculating the bounding rectangle? |
|
How about triggering a digest cycle in a requestanimationframe listener? Might that get us the post-render timing we are looking for? |
|
Thanks for the suggestion @bleathem, just tested it out and it seems to be working great. |
|
Great, glad to hear it worked. I will point out that the requestanimationframe listener will be invoked outside of the digest loop. You might want to consider nesting a $scope.apply, or $timeout to get back into it. If that's not a concern then I'm ok with this approach as it is. |
|
We should update the title of this PR before merging, to make sure the correct description gets into the release notes. @jjlangholtz can you open a parallel PR ro the branch-4.0-dev branch to update the 4.0 component? |
jjlangholtz
changed the title
In #setDropMenuLocation, the bounding rectangle for the menu was being
calculated before it was rendered causing the height to be 0.
For some reason the $timeout was not waiting for the digest cycle to
complete, however, adding a 100 ms delay consistently drops the menu in
the proper direction.
Fixes #399