Create topology graph component #395
Conversation
| * <ul style='list-style-type: none'> | ||
| * <li>.name - name of the item the node represents | ||
| * <li>.status - optional status of the node (can be used to differentiate the circle color) | ||
| * <li>.kind - the kind of node |
There was a problem hiding this comment.
Can you elaborate on what 'kinds' of charts are supported, and what the 'kind' values may be?
Thanks,
- Dave
| angular.module('patternfly.charts').component('pfTopology', { | ||
| bindings: { | ||
| items: '=', | ||
| relations: '=', |
There was a problem hiding this comment.
Hi, do these have to be two way bindings?
|
LGTM 👍 |
| .pf-topology-svg g text.glyph { | ||
| font-size: 20px; | ||
| fill: #1186C1; | ||
| } |
There was a problem hiding this comment.
Lots of additions to A-PF, these should be in Patternfly. Is there a backlog story to move this to Patternfly?
There was a problem hiding this comment.
Not yet - we'll make sure one gets in
| * @restrict E | ||
| * | ||
| * @description | ||
| * Component for rendering a topology chart. Individual nodes and relationships can be represented with this view. CSS is especially important for rendering the noes and lines. The example inline contains specific examples that can be used to change the icon size and the line type of the relationships. |
| "fontfamily": "PatternFlyIcons-webfont" | ||
| } | ||
| }, | ||
| }); |
| font-size: 18px; | ||
| } | ||
| </file> | ||
|
|
There was a problem hiding this comment.
Is it the expectation that applications will want to define each of these?
There was a problem hiding this comment.
Yes, due to the fact that they are text icons - this is the way they'll need to be styled.
| ctrl.$onInit = function () { | ||
| $element.css("display", "block"); | ||
| options = {"force": ctrl.force, "radius": ctrl.radius}; | ||
| //graph = topologyGraph($element[0], notify, options); |
There was a problem hiding this comment.
is this left in for a reason?
| return "unknown"; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
May want to use case insensitive checks here.
This ports the kubernetes-ui component created by Red Hat over to PatternFly with new functionality that has been used by other products.
Inclues unit tests, less for styling and an example of how to style specific nodes, search and filter.