pfCharts: Component Conversion #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-phillips-18
requested changes
Jan 3, 2017
| @@ -64,6 +64,7 @@ | |||
| } | |||
|
|
|||
| $scope.submitform = function (val) { | |||
| console.log("submitform"); | |||
There was a problem hiding this comment.
Please remove console.log
| chartData = ctrl.config; | ||
| if (chartData) { | ||
| chartData.bindto = '#' + ctrl.id; | ||
| $log.info(" -> C3 chart generatd: " + chartData.bindto); |
There was a problem hiding this comment.
is it necessary to $log this?
| }; | ||
| angular.module('patternfly.charts').component('pfC3Chart', { | ||
| bindings: { | ||
| id: '@?', |
There was a problem hiding this comment.
Do we need to bind to id or can we just inject $attrs and get it from there?
| items.push({ | ||
| text: ctrl.legend[index], | ||
| color: ctrl.legendColors[index] | ||
| }); |
There was a problem hiding this comment.
I believe legendItems would need to be updated if ctrl.legend changes. Looks like an existing issue.
| <div ng-if="!loadingDone" class="spinner spinner-lg loading"></div> | ||
| <div ng-if="showLegend" pf-heatmap-legend legend="legendLabels" legend-colors="heatmapColorPattern"></div> | ||
| <pf-empty-chart ng-if="$ctrl.chartDataAvailable === false" chart-height="$ctrl.height"></pf-empty-chart> | ||
| <!--div ng-if="!$ctrl.loadingDone" class="spinner spinner-lg loading"></div--> |
| </div> | ||
| <div class="trend-flat-details-cell"> | ||
| <span class="trend-label-flat-strong-pf">{{config.trendLabel}}</span> | ||
| <span class="trend-label-flat-pf">{{getLatestValue()}} of {{chartData.total + ' ' + config.units}}</span> | ||
| <span class="trend-label-flat-strong-pf">{{$ctrl.nfig.trendLabel}}</span> |
There was a problem hiding this comment.
should this be $ctrl.config?
| </div> | ||
| <div> | ||
| <span> of {{chartData.total}} {{config.units}}</span> | ||
| <span> of {{$ctrl.hartData.total}} {{$ctrl.config.units}}</span> |
There was a problem hiding this comment.
This should be $ctrl.chartData
There was a problem hiding this comment.
Wow, another great catch, thanks!
|
Hi @jeff-phillips-18 ,
|
dgutride
approved these changes
Jan 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the following charts:
Only issue was that pfHeatMap still uses the following to compile it's tooltips:
Will address in a follow up story: PTNFLY-2068