Consolidate dependency management on npm

[dlabrecq]

This PR consolidates the angular-patternfly dependency management on npm for the pf 4 branch.

https://patternfly.atlassian.net/browse/PTNFLY-2035

Note that I'm using lodash-amd in package.json. The npm version of lodash is written for Node.js and uses require to load.

Also note that lodash no longer supports _.findWhere or _.remove. I had to replace functionality in filter-directive.js with _.find and _.filter.

[dtaylor113]

Hi, LGTM. Our README.md needs to be updated, it still refers to:

<!-- Angular -->
<script src="bower_components/angular/angular.min.js"></script>

<!-- Angular-Bootstrap -->
<script src="bower_components/angular-bootstrap/ui-bootstrap.min.js"></script>
<script src="bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js"></script>

Thanks,

• Dave

[dlabrecq]

Thanks, Dave. I updated the readme as well.

[dtaylor113]

I think you missing the 'd' in 'dependency' for this PR title 😄 thank

[dlabrecq]

Anyone else want to review? @bleathem @dgutride

[dlabrecq]

Last chance to review. Going once, twice...

[waldenraines]

Do we still need to install bower here if we're no longer using it?

[dlabrecq]

We don't need bower to build, but Travis still needs to verify the bower install during the release process. (Still supporting both npm and bower installs.) In order for the Travis build to succeed, we still need this line -- for now.

FYI, the Travis build (i.e., the scripts from patternfly-eng-release) will still perform an npm and bower install for all our repos. That is, if there is a bower.json file available. During a release, the scripts will also perform an npm and bower install to verify.

[waldenraines]

👍

[jeff-phillips-18]

👍