Convert card module from directives to components #369
Conversation
|
@dtaylor113 - the boolean/alt-layout is marked as deprecated, not the status card - this is not a change from the current behavior |
|
LGTM. Minor issue, not introduced in this PR, but the card examples titles are sort of looking like params? I don't think the @name likes dashes:
|
| </a> | ||
| </li> | ||
| </ul> | ||
| <div uib-dropdown class="card-pf-time-frame-filter"> |
There was a problem hiding this comment.
Just curious. Was this change because we upgraded to UI Bootstrap?
There was a problem hiding this comment.
Yeah - it actually came in from master (it was a contributed change after we branched for 4.0) - I ported it in so I wouldn't lose the change.
|
LGTM. I'd merge it, but not sure there are any changes need in regard to @dtaylor113 's comment? |
|
My issues shouldn't hold up merging this PR :-) |
|
@dlabrecq @dtaylor113 - I looked into those dashes in the name and we can't change that. ngdocs uses the @name parameter to generate the left-hand navigation and if we remove those dashes, we'll end up with multiple entries in the navigation with the same name. |
|
Ok @dtaylor113, I'll merge. |
This completes the entire card module conversion - all unit tests work, ngdocs work correctly and all examples are building and working.