Add uib prefixes in accordance to migration guide
#353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate deprecated `angular-ui-bootstrap` usage to new `uib`-prefixed versions. Most of the changes apply to dropdowns, modals and tooltips. Also remove classes and aria attributes that are added during link phase for dropdown directives. Tested against latest ManageIQ Service UI and was not able to locate any issues. https://github.com/angular-ui/bootstrap/wiki/Migration-guide-for-prefixes
jjlangholtz
added a commit
to jjlangholtz/manageiq-ui-service
that referenced
this pull request
Dec 1, 2016
Upgrade to the most recent version of `angular-ui-bootstrap`. This includes a significant number of bug fixes and improvements for a library that we heavily use. The biggest breaking change for the upgrade is the addition of a `uib` prefix to all of `angular-ui-bootstrap` directives. This PR updates all deprecated usage to the new version. Because another dependency `angular-patternfly` is still using an older version of `angular-ui-bootstrap`, a few minor things will not work until the upgrade is complete there (the about modal and some tooltips). A PR is open to make the changes there so hopefully it will be updated in the next release patternfly/angular-patternfly#353 https://github.com/angular-ui/bootstrap/wiki/Migration-guide-for-prefixes
|
Hi @jjlangholtz, funny we were just discussing this week how/when to upgrade to latest angular-ui-bootstrap. Thanks for starting this effort! 👍
|
|
@dtaylor113 I believe the version was already bumped in a recent PR https://github.com/patternfly/angular-patternfly/blob/master/bower.json#L43, I was thinking that it could actually be bumped to the latest version |
|
Hi @jjlangholtz, you are correct, we did just update to angular-bootstrap "0.14.x". The migration guide says the new prefixes were introduced in 0.14, so it seems like release 0.14 works with and without the 'uib-' prefixes?
|
|
@dtaylor113 so it looks for the |
jjlangholtz
added a commit
to jjlangholtz/manageiq-ui-service
that referenced
this pull request
Dec 1, 2016
Upgrade to the most recent version of `angular-ui-bootstrap`. This includes a significant number of bug fixes and improvements for a library that we heavily use. The biggest breaking change for the upgrade is the addition of a `uib` prefix to all of `angular-ui-bootstrap` directives. This PR updates all deprecated usage to the new version. Because another dependency `angular-patternfly` is still using an older version of `angular-ui-bootstrap`, a few minor things will not work until the upgrade is complete there (about modal, toolbar, and tooltips). A PR is open to make the changes there so hopefully it will be updated in the next release patternfly/angular-patternfly#353 https://github.com/angular-ui/bootstrap/wiki/Migration-guide-for-prefixes
jjlangholtz
added a commit
to jjlangholtz/manageiq-ui-service
that referenced
this pull request
Dec 1, 2016
Upgrade to the most recent version of `angular-ui-bootstrap`. This includes a significant number of bug fixes and improvements for a library that we heavily use. The biggest breaking change for the upgrade is the addition of a `uib` prefix to all of `angular-ui-bootstrap` directives. This PR updates all deprecated usage to the new version. Because another dependency `angular-patternfly` is still using an older version of `angular-ui-bootstrap`, a few minor things will not work until the upgrade is complete there (about modal, toolbar, and tooltips). A PR is open to make the changes there so hopefully it will be updated in the next release patternfly/angular-patternfly#353 https://github.com/angular-ui/bootstrap/wiki/Migration-guide-for-prefixes
|
Hi @jjlangholtz, thanks for the uib prefix info. Cloned this branch, unit tests all passed, but saw the following issues when reviewing the ngdoc examples (grunt ngdocs:view):
All other ngdoc examples seem to be running fine 😄 |
jjlangholtz
added a commit
to jjlangholtz/manageiq-ui-service
that referenced
this pull request
Dec 5, 2016
Upgrade to the most recent version of `angular-ui-bootstrap`. This includes a significant number of bug fixes and improvements for a library that we heavily use. The biggest breaking change for the upgrade is the addition of a `uib` prefix to all of `angular-ui-bootstrap` directives. This PR updates all deprecated usage to the new version. Because another dependency `angular-patternfly` is still using an older version of `angular-ui-bootstrap`, a few minor things will not work until the upgrade is complete there (about modal, toolbar, and tooltips). A PR is open to make the changes there so hopefully it will be updated in the next release patternfly/angular-patternfly#353 https://github.com/angular-ui/bootstrap/wiki/Migration-guide-for-prefixes
jjlangholtz
added a commit
to jjlangholtz/angular-patternfly
that referenced
this pull request
Dec 5, 2016
Remove intermediate `div` used to `ng-include` the card filter partial. The angular-ui-bootstrap dropdown directives require the `uib-dropdown` directive to be a direct parent of the toggle and menu directives. This change conditionally loads the card filter template without splitting the `uib` dropdown directives. Issue was raised here: patternfly#353
jjlangholtz
added a commit
to jjlangholtz/manageiq-ui-service
that referenced
this pull request
Dec 7, 2016
Upgrade to the most recent version of `angular-ui-bootstrap`. This includes a significant number of bug fixes and improvements for a library that we heavily use. The biggest breaking change for the upgrade is the addition of a `uib` prefix to all of `angular-ui-bootstrap` directives. This PR updates all deprecated usage to the new version. Because another dependency `angular-patternfly` is still using an older version of `angular-ui-bootstrap`, a few minor things will not work until the upgrade is complete there (about modal, toolbar, and tooltips). A PR is open to make the changes there so hopefully it will be updated in the next release patternfly/angular-patternfly#353 https://github.com/angular-ui/bootstrap/wiki/Migration-guide-for-prefixes
jjlangholtz
added a commit
to jjlangholtz/manageiq-ui-service
that referenced
this pull request
Dec 8, 2016
Upgrade to the most recent version of `angular-ui-bootstrap`. This includes a significant number of bug fixes and improvements for a library that we heavily use. The biggest breaking change for the upgrade is the addition of a `uib` prefix to all of `angular-ui-bootstrap` directives. This PR updates all deprecated usage to the new version. Because another dependency `angular-patternfly` is still using an older version of `angular-ui-bootstrap`, a few minor things will not work until the upgrade is complete there (about modal, toolbar, and tooltips). A PR is open to make the changes there so hopefully it will be updated in the next release patternfly/angular-patternfly#353 https://github.com/angular-ui/bootstrap/wiki/Migration-guide-for-prefixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate deprecated
angular-ui-bootstrapusage to newuib-prefixedversions. Most of the changes apply to dropdowns, modals and tooltips.
Also remove classes and aria attributes that are added during link phase
for dropdown directives.
Tested against latest ManageIQ Service UI and was not able to locate any
issues.
https://github.com/angular-ui/bootstrap/wiki/Migration-guide-for-prefixes