Add no-data to linechart #225
Conversation
|
@jeff-phillips-18 @simon3z @zeari please review |
| @@ -1670,6 +1683,7 @@ angular.module('patternfly.charts').directive('pfHeatmap', ["$compile", "$window | |||
| } | |||
| $scope.data = { | |||
| dataAvailable: true, | |||
There was a problem hiding this comment.
@yaacov can't you just detect this by the fact that the data is missing?
There was a problem hiding this comment.
@simon3z this is how trend-chart and heat-maps works, so all the cards will behave the same.
If we do it this way, it will just work in manageiq without changing anything :-) [we set the dataAvailable it just does not work].
Doing it by checking the data will need to change the overview in manageIQ.
There was a problem hiding this comment.
@yaacov ok, it just seems odd to pass an extra flag to signal whether there's data or not.
In the long run you may want to think if it make sense to drop it everywhere (unless I missed a specific use-case).
There was a problem hiding this comment.
@simon3z the example will not work without it :-)
There was a problem hiding this comment.
We added the flag in the angular patternfly directive so the application could differentiate between an empty dataset vs data unavailable.
There was a problem hiding this comment.
We added the flag in the angular patternfly directive so the application could differentiate between an empty dataset vs data unavailable.
@simon3z if you look into the containers dashboard youll see that a dataAvailable flag is the current standard with these patternfly directives.
This matches the rest of the directives so LGTM
|
@jeff-phillips-18 please review |
|
LGTM |
1 similar comment
|
LGTM |
Add "No Data Available" simbol to linechart if no data is available, without this PR it just render an empty div.
With data
No data
