Split pfCard examples to be included separately in patternfly-toolkit. #220
Conversation
|
LGTM: I would just suggest making the titles be: pfCard: Timeframe Filters Either a colon ":" or perhaps a dahs "-". -thanks |
|
I can't do the colon ":", but dash "-" works fine. When colon is added, the "pfCard:" prefix isn't shown. |
dlabrecq
force-pushed
the
PTNFLY-examples
branch
from
35e7e60 to
8db3fef
Compare
|
ok, sounds good |
|
Did you think about putting the examples in a different location from the actual directives? This would have less clutter in the actual code directories and make the examples easily distinguished from additional directives. |
|
I actually tried placing examples under the doc name "patternfly.examples". In this scenario, the directive only contained one example (i.e., utilization), while "pfCard Trend" and "pfCard Timeframe" were split out. The new examples appeared as a block, somewhere in the middle of everything else. My thinking was it may be best to keep all the pfCard examples together? It could be confusing jumping around in order to find all examples? I can throw an example together if you would like to review that, first? |
|
I created an alternate example #221 with pfCard examples under the "patternfly.examples" doc name. Please take a look and let me know what you think? |
|
I think Jeff was just talking about moving the actual files to an 'examples' directory -leaving the ngdoc @NAMEs the same. Just concerned about cluttering up the number of files in the actual directive directories |
|
Ok, that's easy enough. |
|
@dtaylor113 exactly. The concern is more about cluttering the directory and not being clear which files contain examples vs the actual directives. |
|
@jeff-phillips-18, I've moved the new files to their own examples directory. |
…y-toolkit. Added dash "-" to example labels (e.g., "pfCard - Trend") per code review comments. Moved new examples to their own directory. (+1 squashed commit)
dlabrecq
force-pushed
the
PTNFLY-examples
branch
from
dcaf3c4 to
7169bef
Compare
|
LGTM |
1 similar comment
|
LGTM |
@dtaylor113 and @jeff-phillips-18 please review.