Skip to content

Update directives to align with PatternFly documentation terminology #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2016

Conversation

jeff-phillips-18
Copy link
Member

This change is not backwards compatible.
The following name changes are made:

pf-utilization-chart to pf-utlization-trend-chart
pf-simple-filter to pf-filter
pf-simple-filter-results to pf-filter-results
pf-notification to pf-inline-notification
pf-simple-sort to pf-sort
pf-data-list to pf-list-view
pf-data-tiles to pf-card-view

CSS selectors have also been changed from pf- to -pf to be
more inline with PatternFly conventions.

Fixes

@dtaylor113
Copy link
Member

Noticed a few issues:

  1. pfUtilizationTrendChart - Tooltips aren't changing via radiobuttons, only upon switching between 'No Data'
  2. pfToolbar - valid items list columns not aligned
  3. pfToolbar - Actions 'kabob' menu doesn't have the carrot

@jeff-phillips-18 jeff-phillips-18 force-pushed the master branch 2 times, most recently from c990f3c to 99ed22d Compare February 1, 2016 20:35
@jeff-phillips-18
Copy link
Member Author

Fixed 3 issues noted above.

This change is not backwards compatible.
The following name changes are made:

pf-utilization-chart to pf-utlization-trend-chart
pf-simple-filter to pf-filter
pf-simple-filter-results to pf-filter-results
pf-notification to pf-inline-notification
pf-simple-sort to pf-sort
pf-data-list to pf-list-view
pf-data-tiles to pf-card-view

CSS selectors have also been changed from pf-<xxx> to <xxx>-pf to be
more inline with PatternFly conventions.

Fixes
@dtaylor113
Copy link
Member

LGTM

dtaylor113 added a commit that referenced this pull request Feb 1, 2016
Update directives to align with PatternFly documentation terminology
@dtaylor113 dtaylor113 merged commit 753c6c0 into patternfly:master Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants