Skip to content

Topology graph bindings/attributes revisit #631

Closed
@skateman

Description

@skateman

Hi,

as we agreed with @serenamarie125 we're planning to enhance the topology graph with some features introduced in my UI components PR. We looked into the attributes/bindings and found out that it's kinda complicated.

We'd like to remove:

  • icons - and use a fonticon (CSS class) or fileicon (URL) directly on a node.
  • nodes - attribute as it is totally unnecessary, positioning can be done programmatically
  • search- it should live in a parent controller/component
  • kinds - totally unnecessary, a parent controller/component can send the reduced set of data

Also the items could be renamed to nodes as it would make more sense 😉

As the organization of these bindings/attributes might be intentional, I'd like to propose to create a totally new primitive component, let's name it e.g. topologyCanvas which will do one job: render the topology itself. This could contain our refactored code and the pfTopology could contain this component in the future and do the translations between the bindings/attributes if the format is really necessary.

@serenamarie125 and @jeff-phillips-18 what do you guys think? @Hyperkid123 can start working on this immediately.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions