This repository was archived by the owner on Dec 10, 2019. It is now read-only.
Fix errors when file type not found for pattern#26
Open
Josh68 wants to merge 1 commit intopattern-lab:masterfrom
Open
Fix errors when file type not found for pattern#26Josh68 wants to merge 1 commit intopattern-lab:masterfrom
Josh68 wants to merge 1 commit intopattern-lab:masterfrom
Conversation
I kept getting errors if I didn't define scss or js files for patterns, if I had those types in my tabsToAdd option. I think this is a decent fix, but not sure why existing tabFileNameStats.isFile() was not preventing the attempt to copy a non-existent file. In this case, tabFileNameStats is definitively set to null unless the statSync succeeds in the try block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I kept getting errors if I didn't define scss or js files for patterns, if I had those types in my
tabsToAddoption. I think this is a decent fix, but not sure why existingtabFileNameStats.isFile()was not preventing the attempt to copy a non-existent file. In this case,tabFileNameStatsis definitively set to null unless thefs.statSyncsucceeds in the try block.