Skip to content

BUGFIX: lineage url fix #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

scottnath
Copy link

I am using the twig version of pattern lab and I've found a bug where the lineage links are wrong when viewing them inside of the code viewer.

I believe the incorrect code is [inside of lineageHelper.php]:

if (PatternData::getOption($lineage)) {

  $patternLineages[] = array("lineagePattern" => $lineage,
                 "lineagePath"    => "../../patterns/".$patternStoreData["pathDash"]."/".$patternStoreData["pathDash"].".html");

in this case, $patternStoreData["pathDash"] is actually the path to the current pattern, not the lineage. The below change gives the correct path to the lineage pattern.

note: even though this gets the link correct, it hangs when trying to click it. This may be a twig-version issue though...

@scottnath scottnath changed the title lineage url fix BUGFIX: lineage url fix Sep 29, 2015
EvanLovely added a commit that referenced this pull request Oct 9, 2017
…-lineages

Fix for Broken Lineage Functionality in PL When Using Twig templates w/ Path Namespaces (ie. Drupal 8-friendly Paths)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant