Skip to content

fix(patterns): find all patterns inlcuding pseudo patterns #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dersiedler1
Copy link
Contributor

Closes #975

Summary of changes:
find all patterns including pseudo patterns and sort them after
retrieving all patterns instead of inject them in the array working on

find all patterns including pseudo patterns and sort them after
retrieving all patterns instead of inject them in the array working on

fixes issue pattern-lab#975
@sghoweri
Copy link
Contributor

Sweet, thanks @dersiedler1!

AChecking this out later today or early tomorrow (unless @bmuenzenmeyer beats me to it) - hang tight!

@AndrewLeedham
Copy link
Contributor

AndrewLeedham commented Jan 14, 2019

@sghoweri Any update on this? I have come across the same issue described in #975

@sghoweri sghoweri self-requested a review January 14, 2019 19:40
Copy link
Contributor

@sghoweri sghoweri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this seems to fix this buggy psuedo-pattern behavior after replicating the problem mentioned in #975 (comment) -- this update does indeed fix #975!

Side note: While doing some local testing, I did notice that this quirky behavior seemed to (mostly?) happen when things weren't nested in a separate folder (ie organizing patterns like atoms/button.hbs and atoms/button~primary.json but not atoms/buttons/button.hbs and atoms/buttons/button~primary.json) however I think that'll require some more digging around -- separate chunk of work that shouldn't block this one from getting in.

Thanks guys!

@sghoweri sghoweri merged commit 1ef183b into pattern-lab:dev Jan 14, 2019
@AndrewLeedham
Copy link
Contributor

AndrewLeedham commented Jan 15, 2019

I can confirm that this seems to fix this buggy psuedo-pattern behavior after replicating the problem mentioned in #975 (comment) -- this update does indeed fix #975!

Side note: While doing some local testing, I did notice that this quirky behavior seemed to (mostly?) happen when things weren't nested in a separate folder (ie organizing patterns like atoms/button.hbs and atoms/button~primary.json but not atoms/buttons/button.hbs and atoms/buttons/button~primary.json) however I think that'll require some more digging around -- separate chunk of work that shouldn't block this one from getting in.

Thanks guys!

Great thanks @sghoweri. Any ideas when a new beta version might be pushed for @patternlab/core?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants