Skip to content

Feat/927 lerna tests #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2018
Merged

Feat/927 lerna tests #933

merged 2 commits into from
Aug 24, 2018

Conversation

bmuenzenmeyer
Copy link
Member

Closes #927

Summary of changes:

  • Adds test command to uikit-workshop
    • this gets picked up by top-level tests
    • --bail flag is forwarded to build, allowing test to fail when it needs to but regular development / watching to carry on
  • Properly scopes the addition of each engine before testing

@bmuenzenmeyer
Copy link
Member Author

@sghoweri can you take a look at this? I think it's right!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.583% when pulling cfd346c on feat/927-lerna-tests into d1e5f9d on dev.

@sghoweri
Copy link
Contributor

@bmuenzenmeyer I can’t test this out locally till a bit later today however on paper this is exactly what I had in mind (at least as a first step to test that PL’s UIkit is building as expected) — awesome!!

@bmuenzenmeyer bmuenzenmeyer merged commit f2824af into dev Aug 24, 2018
@bmuenzenmeyer bmuenzenmeyer deleted the feat/927-lerna-tests branch August 24, 2018 17:00
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants