Skip to content

UIKit Refactor: Bower to NPM Migration, Partial JS Refactor, and New JS Build Pipeline #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
9266edf
refactor: port over urlHandler
sghoweri Jul 29, 2018
b0b8f66
refactor: port over postmessage.js, fix issues with patternData scope.
sghoweri Jul 29, 2018
9859bc7
refactor: port over data-saver.js; add required dependencies.
sghoweri Jul 29, 2018
9d8fe9b
refactor: port over styleguide.js; add required deps + swap out no lo…
sghoweri Jul 29, 2018
a64c283
refactor: migrate layout.js; add mustache template deps
sghoweri Jul 29, 2018
e490a03
refactor: port over modal-styleguide; add deps + fix JS errors with v…
sghoweri Jul 29, 2018
9daa9a5
refactor: port over modal-viewer.js; add necessary deps + fix JS erro…
sghoweri Jul 29, 2018
ceff63e
refactor: temporarily disable WIP code refactor for updating logic in…
sghoweri Jul 29, 2018
f7b4080
refactor: add required deps to panels-util; fix JS errors from undefi…
sghoweri Jul 29, 2018
e51e3be
refactor: add necessary deps to panels-viewer; fix broken JS; refacto…
sghoweri Jul 29, 2018
2656efc
refactor: port panels JS over; add necessary deps
sghoweri Jul 29, 2018
05d3589
refactor: port over plugin loader; export module so other components …
sghoweri Jul 29, 2018
f0b77ac
refactor: port over pattern-finder; add deps, fix JS errors + add bas…
sghoweri Jul 29, 2018
dfd6d07
refactor: port over prism-languages JS plugin; export module so other…
sghoweri Jul 29, 2018
23a216e
chore: remove clipboard.min.js -- dependency now pulled in via NPM
sghoweri Jul 29, 2018
464ee47
refactor: add new entrypoint files for patternlab-pattern and pattern…
sghoweri Jul 29, 2018
fd3b5a2
refactor: add new typeahead component -- replaces original typeahead …
sghoweri Jul 29, 2018
d094e30
refactor: add new eventemitter util library -- replaces event emitter…
sghoweri Jul 29, 2018
98a47ba
chore: add index.js to utils to simplify pulling in utility libraries…
sghoweri Jul 29, 2018
2ed013f
refactor: remove bower-specific config files and gulp tasks; add corr…
sghoweri Jul 29, 2018
87dd04e
chore: remove old JS build scripts from Gulp; add missing deps to pac…
sghoweri Jul 29, 2018
02e3fc5
refactor: add minified loadJS script loader to PL footer; fix JS path…
sghoweri Jul 29, 2018
1d7dec8
fix: fix JS paths imported
sghoweri Jul 29, 2018
b8a7283
refactor: remove bower components shipped in the dist folder
sghoweri Jul 29, 2018
fec1147
refactor: consolidate built JS bundles
sghoweri Jul 29, 2018
0219880
refactor: add barebones basic Webpack build config
sghoweri Jul 29, 2018
71c7a30
chore: revert adding UIkit-specific deps to root package.json file
sghoweri Jul 29, 2018
94888d4
chore: temporarily disable in-progress UI updates relating to the vie…
sghoweri Jul 29, 2018
564da7a
fix: update PrismJS import
sghoweri Jul 29, 2018
812efe9
fix: add webpack-cli as a uikit-workshop dependency; update npm scrip…
sghoweri Aug 3, 2018
64a2c10
Merge branch 'dev' into feature/remove-bower-refactor-js
sghoweri Aug 3, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/cli/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,13 @@ All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

<a name="0.0.1-alpha.23"></a>
## [0.0.1-alpha.23](https://github.com/pattern-lab/patternlab-node/tree/master/packages/cli/compare/@pattern-lab/cli@0.0.1-alpha.22...@pattern-lab/cli@0.0.1-alpha.23) (2018-07-09)

## [0.0.1-alpha.23](https://github.com/pattern-lab/patternlab-node/tree/master/packages/cli/compare/@pattern-lab/cli@0.0.1-alpha.22...@pattern-lab/cli@0.0.1-alpha.23) (2018-07-09)

### Bug Fixes

* **install:** copy dependencies ([1acef87](https://github.com/pattern-lab/patternlab-node/tree/master/packages/cli/commit/1acef87))





<a name="0.0.1-alpha.22"></a>

## [0.0.1-alpha.22](https://github.com/pattern-lab/patternlab-node/tree/master/packages/cli/compare/@pattern-lab/cli@0.0.1-alpha.21...@pattern-lab/cli@0.0.1-alpha.22) (2018-07-06)
Expand Down
5 changes: 1 addition & 4 deletions packages/edition-node-gulp/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,11 @@ All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

<a name="2.0.0-alpha.15"></a>

# [2.0.0-alpha.15](https://github.com/pattern-lab/patternlab-node/tree/master/packages/edition-node-gulp/compare/@pattern-lab/edition-node-gulp@2.0.0-alpha.14...@pattern-lab/edition-node-gulp@2.0.0-alpha.15) (2018-07-09)

**Note:** Version bump only for package @pattern-lab/edition-node-gulp





<a name="2.0.0-alpha.14"></a>

# [2.0.0-alpha.14](https://github.com/pattern-lab/patternlab-node/tree/master/packages/edition-node-gulp/compare/@pattern-lab/edition-node-gulp@2.0.0-alpha.13...@pattern-lab/edition-node-gulp@2.0.0-alpha.14) (2018-07-06)
Expand Down
6 changes: 1 addition & 5 deletions packages/edition-node/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,13 @@ All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

<a name="1.0.0-alpha.13"></a>
# [1.0.0-alpha.13](https://github.com/pattern-lab/patternlab-node/tree/master/packages/edition-node/compare/@pattern-lab/edition-node@1.0.0-alpha.12...@pattern-lab/edition-node@1.0.0-alpha.13) (2018-07-09)

# [1.0.0-alpha.13](https://github.com/pattern-lab/patternlab-node/tree/master/packages/edition-node/compare/@pattern-lab/edition-node@1.0.0-alpha.12...@pattern-lab/edition-node@1.0.0-alpha.13) (2018-07-09)

### Features

* **scripts:** namespace scripts ([3ecbb3e](https://github.com/pattern-lab/patternlab-node/tree/master/packages/edition-node/commit/3ecbb3e))





<a name="1.0.0-alpha.12"></a>

# [1.0.0-alpha.12](https://github.com/pattern-lab/patternlab-node/tree/master/packages/edition-node/compare/@pattern-lab/edition-node@1.0.0-alpha.11...@pattern-lab/edition-node@1.0.0-alpha.12) (2018-07-06)
Expand Down
3 changes: 0 additions & 3 deletions packages/uikit-workshop/.bowerrc

This file was deleted.

34 changes: 0 additions & 34 deletions packages/uikit-workshop/bower.json

This file was deleted.

26 changes: 5 additions & 21 deletions packages/uikit-workshop/dist/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ <h3 class="pl-c-annotations__item-title">{{ title }}</h3>
<script src="styleguide/data/patternlab-data.js" defer></script>

<!-- applying theme config to get classes on before PL renders so there's no flash of unstyled content -->
<!-- @todo Consider moving this to own file -->
<!-- @todo fold this into it's own standalone JS component -->
<script>
// need to make sure that window.config is defined first on acccount of us async loading everything ;)
window.patternlab = window.patternlab || {};
Expand Down Expand Up @@ -407,31 +407,14 @@ <h3 class="pl-c-annotations__item-title">{{ title }}</h3>
}
</script>

<script src="annotations/annotations.js" async></script>

<!-- load Pattern Lab external library js -->
<script src="styleguide/bower_components/jquery.min.js" defer></script>
<script src="styleguide/bower_components/hogan-3.0.2.min.js" defer></script>
<script src="styleguide/bower_components/prism.min.js" defer></script>
<script src="styleguide/bower_components/jwerty.min.js" defer></script>
<script src="styleguide/bower_components/typeahead.bundle.min.js" defer></script>
<script src="styleguide/bower_components/EventEmitter.min.js" defer></script>
<script src="styleguide/bower_components/script.min.js" defer></script>

<script src="annotations/annotations.js" defer></script>

<!-- load the Pattern Lab viewer js -->
<script>(function(){window.whenDefined=function(e,n,t){e[n]?t():Object.defineProperty(e,n,{configurable:!0,enumerable:!0,writeable:!0,get:function(){return this["_"+n]},set:function(e){this["_"+n]=e,t()}})}}).call(this);</script>
<script>!function(r){var e=function(e,t){"use strict";var n=r.document.getElementsByTagName("script")[0],o=r.document.createElement("script");return o.src=e,o.async=!0,n.parentNode.insertBefore(o,n),t&&"function"==typeof t&&(o.onload=t),o};"undefined"!=typeof module?module.exports=e:r.loadJS=e}("undefined"!=typeof global?global:this);</script>
<script src="styleguide/js/patternlab-viewer.js" defer></script>

<!-- temp workaround to allow everything to be asynced / deffered with current setup. @todo: remove once refactored components + improved build process is in place. -->
<script>
window.Dispatcher;
window.addEventListener('DOMContentLoaded', function () {
window.Dispatcher = new EventEmitter();

// load the Pattern Lab viewer js -- preloaded earlier ^
loadJS('styleguide/js/patternlab-viewer.js');
});

whenDefined(window, 'config', function() {
if (window.config.theme){
window.patternlab.applyTheme();
Expand All @@ -448,6 +431,7 @@ <h3 class="pl-c-annotations__item-title">{{ title }}</h3>
// }
</script>


</body>

</html>
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Loading