Merged
Conversation
Member
bmuenzenmeyer
left a comment
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
Am I right in understanding that this does not catch json errors?
It didn't seem to in my testing
Contributor
Author
|
Try duplicate keys. it definitely catches those |
Member
|
I am going to try moving this to our upstream branch - as I want to shift work towards an alpha there. Apologies if I muck everything up |
Member
|
ugh, that didnt turn out as planned so i reverted |
bmuenzenmeyer
approved these changes
Oct 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Simple change to output the filename and error message of a failed parse to make the problem easier to find when there are multiple json files for a single pattern