Skip to content

Updated host to look for empty string in hostname instead of host #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

donaldpcook
Copy link
Contributor

For #60. This change shouldn't matter, as it resolves to window.location.hostname regardless, but changed it from window.location.host to window.location.hostname for consistency's sake.

@bmuenzenmeyer
Copy link
Member

Hi @donaldpcook can you please change this to merge with the dev branch? If you don't I will change this manually this weekend and close PR.

@donaldpcook
Copy link
Contributor Author

New pull request #71 with this merged into dev.

@ebednarz
Copy link

"This change shouldn't matter, as it resolves to window.location.hostname regardless"

Huh? window.location.host includes the port unless it is the default port for the protocol, and that seems to be exactly what the commit message says. Many (I'd hope most) developers won't run a local server on a port lower than 1024.

@donaldpcook
Copy link
Contributor Author

@ebednarz you can check the commit. The file always saved window.location.hostname to host. It used to check if window.location.host was an empty string. Now it checks if window.location.hostname is an empty string. It shouldn't matter in that if window.location.hostname is or isn't empty, window.location.host is also going to or not going to be empty.

@ebednarz
Copy link

@donaldpcook we might have a minor disagreement about 'always' here :-)
My issue is from 09-16, I now see there is a commit that assigns the locations hostname instead of host property from 09-24: bab8e8c
Your comment was the first notification I got, and missing the above change I admittedly misunderstood what you meant by 'resolves to'.

@bmuenzenmeyer
Copy link
Member

Without looking too far into the past, I suspect my original commit was a typo from a manually-merged PR against master.

Thanks for the discussion and continued interest in patternlab-node!

@donaldpcook
Copy link
Contributor Author

That explains it @ebednarz!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants