Option of excluding sub pattern types from the styleguide#626
Option of excluding sub pattern types from the styleguide#626bmuenzenmeyer merged 5 commits intopattern-lab:devfrom
Conversation
Pattern Lab Node Core 2.7.1
Pattern Lab Node Core 2.7.2
There was a problem hiding this comment.
hey @AndrewLeedham
a surprise but welcome addition! I will try to review this in earnest next chance I get. Can you include a usage example, which Itake it is an additional snippet within patternlab-config.json
core/lib/ui_builder.js
Outdated
| }); | ||
| if (omitPatternType) { | ||
| if (patternlab.config.debug) { | ||
| console.log('Omitting ' + patternType + '/' + patternSubtype + ' from building a viewall page because its patternGroup is specified in styleguideExcludes.'); |
There was a problem hiding this comment.
Should this be pattern subGroup?
There was a problem hiding this comment.
You're not wrong, must of missed that, I'll commit the change now
Changed 'patternGroup' to 'patternSubGroup'
|
@bmuenzenmeyer Thanks for the feedback and quick reply. With regards to usage examples, what do you mean by a snippet? The intention is that sub-types can be specified within the already existing 'styleGuideExcludes' array with the syntax "patternType/subPatternType". Since sub-types are user defined, adding this to the default |
|
By snippet I meant how would one exclude a subtype. would do the trick if I understand correctly |
|
@bmuenzenmeyer Sorry I worded that pretty badly. I meant where do you want me to include the snippet? in the default patternlab-config.json? |
|
just here, so I can make sure to mention it in the release notes or wiki |
|
@bmuenzenmeyer Ah okay fair enough. Yeah you have it right. |
There was a problem hiding this comment.
looks good - and helped me realize that the patternlab-config.json styleguideExcludes should be styleGuideExcludes
created #627
2 participants
Addresses: Option of excluding sub pattern types from the styleguide
Summary of changes: