Deferred engine load #616
Merged
Deferred engine load #616
+520
−458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still reporitng quite a few handlebar tests broken
still reporitng quite a few handlebar tests broken part of #610
…m/pattern-lab/patternlab-node into features/610-deferred-engine-load
…sequently falling through to mustache only one failing unit test now part of #610
|
One thing I am not sure of is why I don't see the commits from @benhalverson from #608. I had to merge that manually which led to this work, but I had expected them to show up here. Any ideas why they aren't reflected? I want you to get credit for those commits. Does this bother you at all Ben? |
|
@raphaelokon can you retry your CLI against |
|
@bmuenzenmeyer Sure will do. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #610
Summary of changes:
pattern_engine.js. This should help control the experience working with core a bit more.There is still one broken unit test, but I intend to look into that separately.