Changed host to hostname to avoid illegal url if a port is used #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @torbs. This pull request is a little messy. If you clean it up to only the change mentioned, it can be researched and accepted. As is, there are too many changes here for me to have time to look through. |
|
Sorry. Forgot to switch branch before I tried some refactoring. I'll create another pull request with only the hostname/host fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window.location.host contains port number localhost:9001
window.location.hostname is without port number
Sync Listeners creates a websocket url using the "host" variable. Therefore the "host" variable cannot contain a port number.