grab chalk and use it to make the build and engine loading process pr…#565
grab chalk and use it to make the build and engine loading process pr…#565bmuenzenmeyer merged 1 commit intodevfrom
Conversation
|
I switched CLI from https://github.com/pattern-lab/patternlab-node-cli/blob/master/bin/utils.js#L10-L25 |
|
I'd like to suggest replacing all console.log statements with more robust logging - with no exceptions. In summary I like the idea :) |
|
@raphaelokon, that looks nice, but what's the benefit of using an event bus for logging, as opposed to just calling a simple logging function directly? @tburny, are you after some kind of delimiter that a parser can grab onto, or timestamps for every log entry, or what? Gulp does something that, and I like that it tells you how long tasks take. |
|
@geoffp |
|
I've endeavored to keep dependencies low - hence the current pretty ghetto implementation. I'd like feedback from users regarding additional, perhaps cosmetic dependencies. I also like the idea @raphaelokon proposed about a better logger. Seems like a more robust way to emit and listen to events of differening importance to the user / use case. |
|
I've come around to this - I created #566 to finish it up. |
|
|
||
| console.log( | ||
| chalk.bold('\n====[ Pattern Lab / Node'), | ||
| `- v${packageInfo.version}`, |
There was a problem hiding this comment.
I really like what this adds to output Geoff
@raphaelokon would you recommend utilizing your event logger in this case then? |
|
The event-based logger just delegates the logging part to the handler function(s) you call … if you call |
I wanted it to be pretty, so I did stuff to it.
