Expose the pattern engines as a property of the patternlab object#555
Merged
bmuenzenmeyer merged 1 commit intopattern-lab:devfrom Nov 16, 2016
Merged
Conversation
128a502 to
039528a
Compare
Member
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
@geoffp pattern engines are your baby - see anything wrong with this? I am cool
Author
|
Here's an example of how I consume the patternlab.engine property in my patternlab-node plugin: |
Member
|
@geoffp poke |
Contributor
|
I have received the poke! I'll check into this. |
Contributor
|
Yeah, I'm cool with it. I had designed the pattern_engines module to be addressable as an array of engines when you require it, just the way I think you want, but being that it's part of patternlab-node, I can see how that would be super awkward from inside a plugin. No harm in hanging another reference on the main PL object. |
Member
|
This will be released with next version - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When developing a patternlab-node plugin, I found it useful to have access to the loaded pattern engines as a property of the patternlab object. This PR introduces an
enginesproperty to thepatternlabobject.