Hide "All" nav item if JSON flag is set#547
Merged
bmuenzenmeyer merged 1 commit intopattern-lab:devfrom Dec 22, 2016
Merged
Conversation
Member
|
Pending a discussion going on at pattern-lab/styleguidekit-assets-default#53 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined with pattern-lab/styleguidekit-assets-default#53 , the existing JSON flag
ishControlsHide.views-allcan be respected (hiding the "All" nav item at the topmost level).Summary of changes:
More specifically, this allows the nav template to access the hiding options set in the JSON
ishControlsHideobject. Previously this object was only accessible to the ish template.