Merged
Conversation
Member
|
Interesting find, something that seems to have been overlooked for a long time. Sounds as if this would make patternType markdown processing easier, something I attempted but ultimately left hanging as #415. I see this just getting a once over and merge - no need for a unit test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
When parsing files at the 0th level (e.g., markdown associated with 1st-level folders), this regex returns
undefined. The|| []was meant to guard against checking.lengthofundefined, but was ineffective due to this missing a pair of parentheses.Should I attempt to add a test for this, or is it simple enough to go in as-is?