more robust parameter to json conversion#276
Merged
bmuenzenmeyer merged 1 commit intopattern-lab:devfrom Feb 28, 2016
e2tha-e:replacing-eval-with-JSON.parse
Merged
more robust parameter to json conversion#276bmuenzenmeyer merged 1 commit intopattern-lab:devfrom e2tha-e:replacing-eval-with-JSON.parse
bmuenzenmeyer merged 1 commit intopattern-lab:devfrom
e2tha-e:replacing-eval-with-JSON.parse
Conversation
Member
|
Looks great - thanks for the thorough improvement and the unit tests! |
bmuenzenmeyer
pushed a commit
that referenced
this pull request
Feb 28, 2016
more robust parameter to json conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #250 (preliminary work)
Summary of changes:
This converter to well-formed JSON will correctly account for different quoting schemes, as well as quotes within quotes for parameter values. Unit tested.