Includes additional twig syntax featires #1367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"from," "import" and "use" are both twig built-in, and uses the same techniques as include, embed etc when resolving template names.
Some twig templates use {%- ... -%} syntax that gobble up the whitespace on each side. This change ensures that this syntax is understood when looking for partials.
Will this break any existing functionality? |
No, it shouldn't. This code is only used when determining the "graph" of template dependencies, as far a I know. Twig understands the |
|
I noticed I changed "engine-twig" and not "engine-twig-php" which I linked for documentation purposes; I should probably do both, and align this properly. |
JosefBredereck
approved these changes
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The twig tags "from," "import" and "use" are not understood by patternlab. They all use the same techniques as include, embed etc when resolving template names.
fromis documented in macros:Some twig templates use {%- ... -%} syntax that gobble up the whitespace on each side. This change ensures that this syntax is understood when looking for partials.
I wasn't aware of the
{%~syntax (line-whitespace trimming) introduced in 2.8; I could add support for that too.