refactor: optimized engines directory retrieval #1359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
especially for npm workspaces usage (aka npm 7 monorepos)
JosefBredereck
added a commit
that referenced
this pull request
Oct 16, 2021
This reverts commit 37d19d4.
JosefBredereck
added a commit
that referenced
this pull request
Oct 16, 2021
|
This PR needs to be reopened |
|
I needed to make a small optimization on my initial merge requests code due to problems when running in pattern lab codebase clone and opened a new pull request for this: #1364 |
JosefBredereck
added a commit
that referenced
this pull request
Nov 3, 2021
* refactor: replacing existing way to retrieve the actual node_directory especially for npm workspaces usage (aka npm 7 monorepos) * refactor: outputting the engines directory path as well for debugging * fix: we'll still need the process.cwd entry especially for development in the PL codebase itself Co-authored-by: Josef Bredreck <slime.games@outlook.de> Co-authored-by: Josef Bredreck <13408112+JosefBredereck@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1347
Summary of changes:
The logic for resolving the path to engines directories has been implemented long before
npm workspacesgot introduced (actually with commit 416132c in mid 2016), so we would need to refactor this implementation.