refactor: further optimizations #1335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<html> element must have a lang attribute: The <html> element does not have a lang attribute more information: https://dequeuniversity.com/rules/axe/4.2/html-has-lang
78 tasks
I've added that documentation entry with pattern-lab#1313, but sadly missed to remove that incorrect sentence that belongs to another section on that page.
JosefBredereck
approved these changes
Aug 7, 2021
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
* refactor(accessibility): axe/language - added lang attribute <html> element must have a lang attribute: The <html> element does not have a lang attribute more information: https://dequeuniversity.com/rules/axe/4.2/html-has-lang * chore: replaced individual random function by the one provided as a utility * chore: prettier code formatting * chore: prettier code formatting * chore: eslint feedback * chore: reverted those previously incorrectly checked in files * docs: removed incorrect sentence out of pattern-lab#1313 I've added that documentation entry with pattern-lab#1313, but sadly missed to remove that incorrect sentence that belongs to another section on that page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
axe/language- added lang attributeprettier&ESLintcode reformattingThe failing
Code scanning results / CodeQLjob isn't related to code "changes" that are provided with this merge request, as the code has only been reformatted, and I've included those aspects within the ticket #1337 for further investigation.