refactor: code style optimizations #1314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'matches' is never reassigned. Use 'const' instead
'e' is already declared in the upper scope on line 202 column 24
'port' is already declared in the upper scope on line 28 column 9
@deprecated — use equal() instead. 'equals' is deprecated.ts(6385) index.d.ts(53, 8): The declaration was marked as deprecated here.
'fs' is declared but its value is never read.ts(6133)
This reverts commit fd3964c.
mfranzke
changed the title
JosefBredereck
approved these changes
May 17, 2021
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
* chore(beautify): dependency reordering after npm i * refactor: eslint feedback / prefer-const 'matches' is never reassigned. Use 'const' instead * refactor: eslint feedback / prettier * refactor: eslint feedback / no-shadow 'e' is already declared in the upper scope on line 202 column 24 * refactor: eslint feedback / no-shadow 'port' is already declared in the upper scope on line 28 column 9 * chore: typo * test(eslint): error / Unexpected var, use let or const instead / no-var * refactor: eslint feedback / prettier/prettier * refactor(test): equals() is deprecated, replaced by equal() @deprecated — use equal() instead. 'equals' is deprecated.ts(6385) index.d.ts(53, 8): The declaration was marked as deprecated here. * refactor: removed unused variables 'fs' is declared but its value is never read.ts(6133) * refactor: eslint & prettier fixes * refactor: code formatting via prettier * Revert "refactor: removed unused variables" This reverts commit fd3964c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Integrated several simple code optimizations, like:
--fix)