chore(build): update Twing dependency #1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the 4 to 5 upgrade impact end users? |
|
@bmuenzenmeyer I tested it locally and there were no regressions AFAICS. But one of the fixed issues regarding relative imports triggered me to test it regarding the issue I asked your help for. |
|
@bmuenzenmeyer could this get merged? I am hoping to test |
|
I saw the other message about uneven head and foot calls. Does this engine or the twig library render as promises? (Thanks for patience recently, I'm swamped at work) |
|
Yes it does. See the section |
|
PR was released with v5.11.1 |
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
chore(build): update Twing dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes: