fix(uikitworkshop): preventing cropping pattern parts #1174 #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absolutely positioned pattern parts at the vertical end of the "page" would get cropped elsewhere
|
this seems reasonable - @sghoweri do you have time to review ? |
…rn-parts-at-the-vertical-end-of-the-page-would-get-cropped
…rn-parts-at-the-vertical-end-of-the-page-would-get-cropped
…rn-parts-at-the-vertical-end-of-the-page-would-get-cropped
…rn-parts-at-the-vertical-end-of-the-page-would-get-cropped
…rn-parts-at-the-vertical-end-of-the-page-would-get-cropped
…rn-parts-at-the-vertical-end-of-the-page-would-get-cropped
Sorry, just go around to looking at this. Looks good to me! |
…rn-parts-at-the-vertical-end-of-the-page-would-get-cropped
sghoweri
approved these changes
May 9, 2020
…rn-parts-at-the-vertical-end-of-the-page-would-get-cropped
mfranzke
deleted the
fix-uikitworkshop-absolutely-positioned-pattern-parts-at-the-vertical-end-of-the-page-would-get-cropped
branch
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
…bsolutely-positioned-pattern-parts-at-the-vertical-end-of-the-page-would-get-cropped fix(uikitworkshop): preventing cropping pattern parts pattern-lab#1174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
absolutely positioned pattern parts at the vertical end of the "page" would get cropped elsewhere
Closes #1174
Summary of changes:
Refactoring parts of commit 123427a as this would elsewhere crop vertically as well, whereas the declaration out of commit 123427a was most likely mainly meant to function horizontally.
Problem:
I've been able to rebuild a simplified example here: https://output.jsbin.com/munabac/1
Only the first item within the "collapsing menu" (after pressing the interaction element "Toggle Overflow menu") is visible within the second pattern.