Skip to content

Docs #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 169 commits into from
Apr 17, 2020
Merged

Docs #1147

merged 169 commits into from
Apr 17, 2020

Conversation

bmuenzenmeyer
Copy link
Member

@bmuenzenmeyer bmuenzenmeyer commented Apr 17, 2020

Closes bradfrost/pl-website-eleventy#23

Summary of changes:

  • uses lerna import to bring in the new site
  • yarnify's everything
  • used to setup netlify docs preview
  • also turned off the "header", "Pages changed", "redirect rules", and "mixed content" messages in netlify - so we should be able to declutter that going forward,
  • submitted a netlify form to get an open source team account - it will be better long term than using mine

@bmuenzenmeyer bmuenzenmeyer self-assigned this Apr 17, 2020
@sghoweri
Copy link
Contributor

@bmuenzenmeyer +1 on having deploy previews of the Handlebars PL demo as well as a separate deploy previews of the new docs site 👏!

@sghoweri
Copy link
Contributor

Just one quick question for @bmuenzenmeyer and/or @bradfrost:

If I'm seeing UI bugs, 404s, old docs info, etc -- should I comment on those here OR should this PR just be focused on moving the bulk of the new docs site work over and we handle any small fixes separately?

I'd prefer us handling those separately but wanted to check with you guys first... didn't want to add a bunch of changes requested if the whole point of this PR was just to add the new docs site to the monorepo and not much else 😜.

@bmuenzenmeyer
Copy link
Member Author

@sghoweri IMO this effort was to port over the work already done - not get it perfect

any issues with the site itself should be separate tickets and fixes - now with more preview!

when we're ready, we can start deploying this for real (as in making patternlab.io point to it)

@sghoweri
Copy link
Contributor

@sghoweri IMO this effort was to port over the work already done - not get it perfect

any issues with the site itself should be separate tickets and fixes - now with more preview!

when we're ready, we can start deploying this for real (as in making patternlab.io point to it)

Awesome so if that's the case then this gets the go-ahead from my point of view -- good call pulling this in via lerna import btw 🙂

Copy link
Contributor

@sghoweri sghoweri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! 🚀

@bmuenzenmeyer bmuenzenmeyer merged commit a2062dd into dev Apr 17, 2020
@bmuenzenmeyer bmuenzenmeyer deleted the docs branch April 17, 2020 12:34
@bradfrost
Copy link
Member

@bmuenzenmeyer @sghoweri what are the next steps to get the site live? Wait for the Netlify open source team stuff to go through and then point the patternlab.io domain over?

@bmuenzenmeyer
Copy link
Member Author

assuming https://patternlab-docs-preview.netlify.app/ passes muster and we all agree

  1. Change the production branch to master instead of dev
  2. Point the patternlab.io domain over. I've done that in the past - but am unsure if its different when i don't own all ends of the dns config. 🤷

I assume (2) would be simpler if you have access to the netlify dashboard, which could come with the team or if I can somehow give you direct access to my team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate into PL monorepo
5 participants