-
Notifications
You must be signed in to change notification settings - Fork 404
Docs #1147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs #1147
Conversation
Feature/jsdom integration
Feature/front end first pass
Feature/rss
@bmuenzenmeyer +1 on having deploy previews of the Handlebars PL demo as well as a separate deploy previews of the new docs site 👏! |
Just one quick question for @bmuenzenmeyer and/or @bradfrost: If I'm seeing UI bugs, 404s, old docs info, etc -- should I comment on those here OR should this PR just be focused on moving the bulk of the new docs site work over and we handle any small fixes separately? I'd prefer us handling those separately but wanted to check with you guys first... didn't want to add a bunch of changes requested if the whole point of this PR was just to add the new docs site to the monorepo and not much else 😜. |
@sghoweri IMO this effort was to port over the work already done - not get it perfect any issues with the site itself should be separate tickets and fixes - now with more preview! when we're ready, we can start deploying this for real (as in making patternlab.io point to it) |
Awesome so if that's the case then this gets the go-ahead from my point of view -- good call pulling this in via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it! 🚀
@bmuenzenmeyer @sghoweri what are the next steps to get the site live? Wait for the Netlify open source team stuff to go through and then point the patternlab.io domain over? |
assuming https://patternlab-docs-preview.netlify.app/ passes muster and we all agree
I assume (2) would be simpler if you have access to the netlify dashboard, which could come with the team or if I can somehow give you direct access to my team |
Closes bradfrost/pl-website-eleventy#23
Summary of changes:
lerna import
to bring in the new site