Skip to content

Allow using --watch option in patternlab build #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 23, 2020

Conversation

drhossa
Copy link
Contributor

@drhossa drhossa commented Jan 24, 2020

Summary of changes:

  • core/src/lib/patternlab.js: reset patterns before updating
  • core/src/lib/watchPatternLabFiles.js: add unlink events to patternWatcher
  • cli/bin/build.js: allow passing the watch flag

@drhossa drhossa requested a review from raphaelokon as a code owner January 24, 2020 16:25
@drhossa drhossa changed the title Allow using Allow using --watch option in patternlab build Jan 24, 2020
@bmuenzenmeyer
Copy link
Member

this looks awesome! hope to review soon

@stale
Copy link

stale bot commented Apr 3, 2020

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@stale
Copy link

stale bot commented Jun 28, 2020

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@mfranzke
Copy link
Contributor

Fight the bot

@JosefBredereck
Copy link
Contributor

Need to mention
Closes #887

@JosefBredereck JosefBredereck removed the request for review from raphaelokon August 18, 2020 16:47
@JosefBredereck JosefBredereck merged commit 5d09bb0 into pattern-lab:dev Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants