Skip to content

Fix Handlebars Demo's defaultPattern + Minor UIKit Tweaks #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2019

Conversation

sghoweri
Copy link
Contributor

@sghoweri sghoweri commented Oct 23, 2019

  • Updates the Handlebars demo's default pattern config to fix the "empty" page that initially shows up.
  • Adds a small amount of inner padding to partially address Frame size indicator and pattern Iframe padding #1062
  • Reduces the global header shadow size just a tad + reduces the max logo height to make the global header's default height a bit more reasonable

@@ -1,12 +1,12 @@
{
"cacheBust": true,
"cleanPublic": true,
"defaultPattern": "atoms-swatch",
"defaultPattern": "all",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this catch! it makes sense now

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.373% when pulling e4675f1 on fix/fix-handlebars-demo-and-small-uikit-tweaks into 3f89dda on dev.

@bmuenzenmeyer bmuenzenmeyer merged commit 93d6f40 into dev Oct 23, 2019
@bmuenzenmeyer bmuenzenmeyer deleted the fix/fix-handlebars-demo-and-small-uikit-tweaks branch October 23, 2019 13:35
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
…rs-demo-and-small-uikit-tweaks

Fix Handlebars Demo's defaultPattern + Minor UIKit Tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants