UIKit Code Panel + View All / Clean Public Fixes!

[sghoweri]

Summary

• Fixes several long running bugs relating to Code Panels, including View All page panels being completely broken after the first initial build of Pattern Lab, only being able to open one panel at a time while on View All pages (when they do work), and panels only being able to be opened / closed once before breaking...
• Also fixes a semi-related issue I encountered regarding the broken cleanPublic config option... turns out that without the cleanPublic option enabled, the code panels also don't appear to get the data needed in order to work properly!
• This PR also tries to patch up some Navigation / Viewport bugs I've observed where loading up certain pages for the first time (via query string parameter) don't (always?) end up loading up in the iframe as expected
  • Note: I haven't 100% confirmed this however this could actually be related to the cleanPublic option not working as expected...
• Finally this PR also does some minor CSS cleanup with the code panel so the copy button doesn't start to overflow off the screen + the code panel height on View All pages (when expanded) is the height of the content itself (at least on larger screen sizes)

Bugs Fixed

• Code panel expanding bug #1057
• [uikit-workshop] View All Drawers Do Not Open #1029
• cli package cleanPublic option broken #1024
• cleanPublic not working #988

[coveralls]

Coverage decreased (-0.7%) to 73.688% when pulling 5f53f60 on feature/uikit-panel-related-fixes into 2fe8cd4 on dev.

[bmuenzenmeyer]

@sghoweri curious if you are also seeing this ? (when clicking on the logo)

on the hosted dev preview I see this:

[sghoweri]

Hmmm 🤔

@bmuenzenmeyer let me dig a bit more into this one — I might try to split this up into two PRs (plus see if I can sprinkle a little Jest help as well to start chipping away at UIKit testing coverage...)

Hang tight!

[bmuenzenmeyer]

FYI, I had to make a minor uikit change here as part of a plugin fix. https://github.com/pattern-lab/patternlab-node/pull/1077/files#diff-963382f8b9962328c07d8308327620c7 Not sure if related (I probably should start having you review instead of late night merging)

…

On Wed, Oct 16, 2019, 5:18 AM Salem Ghoweri ***@***.***> wrote: Hmmm 🤔 @bmuenzenmeyer <https://github.com/bmuenzenmeyer> let me dig a bit more into this one — I might try to split this up into two PRs (plus see if I can sprinkle a little Jest help as well to start chipping away at UIKit testing coverage...) Hang tight! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1074?email_source=notifications&email_token=AACI3Q62F46H63Y3QCEN5K3QO3S6LA5CNFSM4JAFBXHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBL6XII#issuecomment-542632865>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACI3Q5HL4I3M23YPRO54OLQO3S6LANCNFSM4JAFBXHA> .

[bmuenzenmeyer]

the hosted preview now also shows the same behavior i was seeing locally

[bmuenzenmeyer]

superceded by #1094

@sghoweri if I am misunderstanding - please reopen

[sghoweri]

superceded by #1094

@sghoweri if I am misunderstanding - please reopen

Nope, all good. #1094 supersedes this one 👍🏼