Skip to content

"M" button is using the ishViewportRange #930

Closed
@bmuenzenmeyer

Description

@bmuenzenmeyer

I am using Pattern Lab Node v3.0.0 on Windows, with Node v8.9.4, using a Gulp Edition.

Expected Behavior

Hittin the "M" button in Pattern Lab's UI should set a viewport size within the range defined within "m" below

  "ishViewportRange": {
    "s": [240, 500],
    "m": [500, 800],
    "l": [800, 2600]
  },
Actual Behavior

Uses "s" values. styleguide.js

  // handle medium button
  function goMedium() {
    killDisco();
    killHay();
    fullMode = false;
    sizeiframe(
      getRandom(
        minViewportWidth,
        config.ishViewportRange !== undefined
          ? parseInt(config.ishViewportRange.s[1])
          : 500
      )
    );
  }
Steps to Reproduce

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions