View All Broken

[bmuenzenmeyer]

I am using Pattern Lab Node v3.0.0-alpha.11 on Windows, with Node v8.9.4, using a Gulp Edition.

Expected Behavior

Actual Behavior

Steps to Reproduce

Click on the Pattern Type Title
"View All" menu options similarly do not work

[julrich]

It seems the link is broken already when the footer is inserted here:
https://github.com/pattern-lab/patternlab-node/blob/master/packages/core/src/lib/buildFooter.js#L35

It inserts {"patternPartial":"viewall-atoms-0"} for me, for example. Where it should insert viewall-atoms-buttons, for example.

Still not sure where it goes wrong exactly.

Used a conditional on the breakpoint to catch it (used footerPartial.indexOf('-0') > -1; for that).

[bmuenzenmeyer]

thanks for the additional info!

[julrich]

Not proposing this as the actual fix, because it feels like this should be solvable much cleaner, but this fixed the problem for me, for now:
https://github.com/ruhmesmeile/patternlab-node/pull/2/files

Basically patternSubtype seems to be just an index, not the name of the pattern. I could retrieve it like this, which seems to fix the structure of the link in the generated footer / view all pattern:

{"patternPartial":"viewall-atoms-button"}

instead of:

{"patternPartial":"viewall-atoms-0"}

Unfortunately I still have one component which doesn't get the view all pattern file generated at all. 06-organisms-footer in my case is missing, whereas 06-organisms-header gets a folder with its corresponding index.html. They have no obvious differences in structure or content to me, which confuses me. They are in the same group, and the header comes first. So probably the loop logic is broken, and just the first one in a group is picked up right now? Or I broke it with my changes?

Another group with just one pattern in it works flawlessly.

[bmuenzenmeyer]

Basically patternSubtype seems to be just an index, not the name of the pattern

This certainly sounds like the case. I am curious if it was a regression on my part as part of the pretty massive async refactor. Cleaning up all the ui_builder code with this issue in mind will help. I'll dig into this soon! My first step will be trying to isolate this behavior to the point where we can write a failing unit test.

[julrich]

Added some more fixes to the PR above, with those changes, at least it's behaving consistently.

I think the let p; needs to be scoped like this, because otherwise in this line:
https://github.com/pattern-lab/patternlab-node/blob/master/packages/core/src/lib/ui_builder.js#L595

the same path is re-used for different patterns, resulting in only one of them getting it's viewall- index.html file.

[stale]

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!