Replace all var with let/const

[tburny]

I am using Pattern Lab Node v2.7.2 on Linux, with Node v4.6.2.

For consistency and code quality we should replace all existing var keywords with let or const for safer variable scoping.

[benhalverson]

@tburny I'm working on this 👍

[tburny]

Great :)

[bmuenzenmeyer]

Thanks for offering your help @benhalverson.

I am a bit worried that submitting this PR against dev would lead to many conflicts with the async work going on. I suggest working against a version of that.

@geoffp to reduce all of this confusion, but leave dev open for 2.X work, are you alright with moving your async work into a dev3.0 branch?

[bmuenzenmeyer]

@benhalverson @tburny @geoffp @raphaelokon I have branched the latest async stuff I could was reported stable to dev-3.0

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[benhalverson]

🙄

[bmuenzenmeyer]

@benhalverson stalebot tries so hard - it was supposed to ignore "staged for next release issues"

[benhalverson]

@bmuenzenmeyer I think it needs to go back to parsing hot dog or not hot dog images 🤣