Skip to content

ListItem Partials Render with Previously Found Partial's StyleModifier #356

Closed
@bmuenzenmeyer

Description

@bmuenzenmeyer

I am using Pattern Lab Node v2.0.0 onWindows, using thegulp` edition.

Found on a private instance of PL/Node 2.0.0 in prep for WDD 2016.

Expected Behavior

Running blockset.mustache

<section class="blockset {{#vertical}}blockset__vertical{{/vertical}}">
  {{> molecules-block }}
{{#listItems.three}}
  {{> molecules-block }}
{{/listItems.three}}
</section>

should emit blocks with no styleModifier using this pattern

block.mustache

<div class="block {{styleModifier}}">
  {{> atoms-picture }}
  {{> atoms-paragraph }}
</div>

Actual Behavior

Actual output includes the previously found molecules-block with the styleModifier class added.
since this was already parsed

block-hero.mustache

{{> molecules-block:block__hero }}

was already parsed and is polluting this list item parsing.

We have a bunch of unit tests covering pattern parameters, but either regressed or omitted styleModifiers.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions