Since 5.7.0, PL menu structure breaks if filename and subfolder name match

[coreylafferty]

I am using Pattern Lab Node v5.7.1 on Windows, with Node v10.15.1.

Expected Behavior

Folder names and file names should not break the menu if they happen to be the same.

Actual Behavior

Prior to 5.7.0, the menu worked as expected when subfolder names and file names matched. Since 5.7.0, menu functionality breaks when this is the case. Clicking on submenu items will display the wrong items or no item at all.

@bmuenzenmeyer @david-moldenhauer I believe this is due to the changes from this PR, specifically these lines:
https://github.com/pattern-lab/patternlab-node/pull/1016/files#diff-811dc08dbb9437f8b472a21f0c9bd66eR38-R40

Steps to Reproduce

Install a fresh copy of PL and create the following files/folders in /source/_patterns/:

02-organisms/broken/broken.twig
02-organisms/broken/broken-item1/broken-item1.twig
02-organisms/broken/broken-item2/broken-item2.twig

Open PL in the browser and click the arrow next to the 'Broken' menu under 'Organisms' then click on the first child (Broken Item2). Note that it will actually show the wrong item and mark the wrong item as active in the menu.

The issue here seems to be that the subfolder name (e.g., broken-item1) and the filename in it (broken-item1.twig) are identical (ignoring the file extension).

To contrast, create the following files/folders in /source/_patterns/ to see an almost identical situation, but where everything works as expected. The only difference here is that the subfolder file name (e.g., working1) does NOT match the filename in it (e.g., working-item1).

02-organisms/working/working.twig
02-organisms/working/working1/working-item1.twig
02-organisms/working/working2/working-item2.twig

[ringods]

Have you tried the pure JS twig engine from @pattern-lab/engine-twig lately? It got a big refresh in version 5.8.0 by using a better library under the hood.

[coreylafferty]

Thanks, @ringods. I think this is more tied to the PL navigation creation. This issue appears to be fixed by PR #1143, which appears to be close to being accepted.

[stale]

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

[mfranzke]

Fight the bot

[JosefBredereck]

Fixed with #1143 in V5.12.0