Skip to content

Mega PR: Merging Drupal Pattern Lab's Twig Pattern Engine Fork Back Into the Main Pattern Lab PHP Twig Pattern Engine Repo #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 9, 2017

Conversation

sghoweri
Copy link

@sghoweri sghoweri commented Oct 7, 2017

This folds in the past 5 months worth of maintenance and enhancement updates made to the Drupal Pattern Lab working group's ongoing Pattern Lab PHP Core and Pattern Lab Twig Engine (this repo) forks as part of the new exciting updates @bradfrost posted about earlier this week!

Changelog:

  • FIX: Fix long broken lineage functionality when using Twig namespaces (ie. Drupal 8 friendly paths) + picks up extends and embeds as lineages as well. Closes out #105 and related to the #129 Mega Issue | @sghoweri and @aleksip
  • CHORE: Merge Pattern Lab Twig Engine dev work @dmolsen helped with back in May of 2016 | @dmolsen, @EvanLovely and @sghoweri

TODOs

  • [ ] remove references to Drupal Pattern Lab in composer.json
  • [ ] move existing PRs / Issues over to main Pattern Engine PHP Twig repo

@sghoweri sghoweri changed the title Mega PR: Merging Drupal Pattern Lab's Twig Pattern Engine Fork Back Into the Main Twig Pattern Engine Repo Mega PR: Merging Drupal Pattern Lab's Twig Pattern Engine Fork Back Into the Main Pattern Lab PHP Twig Pattern Engine Repo Oct 7, 2017
@EvanLovely EvanLovely self-assigned this Oct 9, 2017
@EvanLovely EvanLovely self-requested a review October 9, 2017 17:40
@EvanLovely EvanLovely changed the base branch from master to feature/drupal-pl October 9, 2017 17:44
@EvanLovely
Copy link
Member

@sghoweri I just changed the base branch of this pr from master to feature/drupal-pl so we can merge it in and then make changes on that feature branch before merging in.

@EvanLovely EvanLovely merged commit b8dc262 into pattern-lab:feature/drupal-pl Oct 9, 2017
EvanLovely added a commit that referenced this pull request Oct 9, 2017
* Fixing lineage config line

Mega PR: Merging Drupal Pattern Lab's Twig Pattern Engine Fork Back Into the Main Pattern Lab PHP Twig Pattern Engine Repo (#44)

* updating dev-dev dependencies

* fixing failing constraint

* Testing regex updates meant for composer.json-based consumption. Not nearly as easy as copying over from the config.yml file...

* Adding original for testing comparison

* Testing updated and simplified regex which also fixes lineages when using D8 friendly Twig paths

* Updating registered namespace to Drupal Pattern Lab

* Revert "Updating registered namespace to Drupal Pattern Lab"

This reverts commit ba07a6e.

* updating info

* Remove reference to Drupal Pattern Lab fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants