Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vercel build #55

Merged
merged 6 commits into from
Dec 17, 2020
Merged

Vercel build #55

merged 6 commits into from
Dec 17, 2020

Conversation

ccorda
Copy link
Contributor

@ccorda ccorda commented Dec 6, 2020 •
edited
Loading

  • Docs on Vercel
  • Specify engine to match .nvmrc
  • Move bundle analyzer to deps, otherwise vercel would error out

@ccorda ccorda requested a review from kylehotchkiss December 6, 2020 06:06
@vercel
Copy link

vercel bot commented Dec 6, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/patronage/bubs-next/h4inizg5g
✅ Preview: Canceled

[Deployment for 1620580 canceled]

@ccorda
Copy link
Contributor Author

ccorda commented Dec 6, 2020

@kylehotchkiss can you give this a review?

kylehotchkiss
kylehotchkiss approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@kylehotchkiss kylehotchkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a .nvmrc in wordpress/ as well? Otherwise LGTM

@ccorda ccorda merged commit d871e40 into main Dec 17, 2020
@ccorda ccorda deleted the vercel-build branch December 17, 2020 22:18
ccorda added a commit that referenced this pull request Mar 7, 2021
@ccorda
Merge branch 'main' into docs-better-init
ab5b19d 
* main:
  Vercel build docs (#55)

# Conflicts:
#	docs/hosting.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehotchkiss kylehotchkiss kylehotchkiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccorda @kylehotchkiss