Skip to content

Commit 175d48b

Browse files
committed
refactor(android): update close method to return Promise<Unit>
1 parent 4fa8d41 commit 175d48b

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

android/src/main/java/com/nitroinappbrowser/HybridNitroInAppBrowser.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import com.margelo.nitro.core.Promise
55
import com.margelo.nitro.nitroinappbrowser.HybridNitroInAppBrowserSpec
66
import com.margelo.nitro.nitroinappbrowser.NitroInAppBrowserOptions
77
import kotlinx.coroutines.MainScope
8-
import kotlinx.coroutines.launch
98

109
class HybridNitroInAppBrowser: HybridNitroInAppBrowserSpec() {
1110
private val inAppBrowser = NitroInAppBrowserImpl(NitroModules.applicationContext)
@@ -17,8 +16,8 @@ class HybridNitroInAppBrowser: HybridNitroInAppBrowserSpec() {
1716
}
1817
}
1918

20-
override fun close() {
21-
scope.launch {
19+
override fun close(): Promise<Unit> {
20+
return Promise.async(scope) {
2221
inAppBrowser.close()
2322
}
2423
}

nitrogen/generated/android/kotlin/com/margelo/nitro/nitroinappbrowser/HybridNitroInAppBrowserSpec.kt

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)