Skip to content

Commit 4fa8d41

Browse files
committed
fix(android): ensure open and close run on main thread
1 parent ef9cfa9 commit 4fa8d41

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

android/src/main/java/com/nitroinappbrowser/HybridNitroInAppBrowser.kt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,22 @@ import com.margelo.nitro.NitroModules
44
import com.margelo.nitro.core.Promise
55
import com.margelo.nitro.nitroinappbrowser.HybridNitroInAppBrowserSpec
66
import com.margelo.nitro.nitroinappbrowser.NitroInAppBrowserOptions
7+
import kotlinx.coroutines.MainScope
8+
import kotlinx.coroutines.launch
79

810
class HybridNitroInAppBrowser: HybridNitroInAppBrowserSpec() {
911
private val inAppBrowser = NitroInAppBrowserImpl(NitroModules.applicationContext)
12+
private val scope = MainScope()
1013

1114
override fun open(url: String, options: NitroInAppBrowserOptions?): Promise<Unit> {
12-
return Promise.async {
15+
return Promise.async(scope) {
1316
inAppBrowser.open(url, options)
1417
}
1518
}
1619

1720
override fun close() {
18-
inAppBrowser.close()
21+
scope.launch {
22+
inAppBrowser.close()
23+
}
1924
}
2025
}

0 commit comments

Comments
 (0)