feat: add promtail_extra_args variable to allow configuring the service arguments #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickjahns
added
enhancement
|
Thank you for your contribution - this looks good to me overall Some nitpicks, can you please:
Can I ask, if you have tested the feature already? |
…ce arguments add promtail_extra_args add promtail_extra_args add promtail_extra_args
|
Hi there, it is already testet in mutliple deployments. |
sfhl
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
to be able to set an extra label, for example
hostnamethis adds the possbility to define extra-args for the binary within the service file.closes #167