Skip to content

Add module-info via moditect#64

Open
bowbahdoe wants to merge 1 commit intopatrickfav:mainfrom
bowbahdoe:main
Open

Add module-info via moditect#64
bowbahdoe wants to merge 1 commit intopatrickfav:mainfrom
bowbahdoe:main

Conversation

@bowbahdoe
Copy link

@bowbahdoe bowbahdoe commented Nov 25, 2023

Addresses #63

Before:

> jlink -p target/bytes-1.6.2.jar --add-modules at.favre.lib.bytes --output jre

Error: automatic module cannot be used with jlink: at.favre.lib.bytes from file:///Users/emccue/Development/bytes-java/target/bytes-1.6.2.jar

After:

> jlink -p target/bytes-1.6.2.jar --add-modules at.favre.lib.bytes --output jre
> ./jre/bin/java --list-modules
at.favre.lib.bytes@1.6.2
java.base@21.0.1
jdk.internal.vm.ci@21.0.1

@bowbahdoe
Copy link
Author

@patrickfav Do you have any time to get around to this? I'll send you a 🍕 if you give me a venmo or an address to send it to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant