Skip to content

Fix missing gpg sign and add correct maven deploy flow #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickfav merged 1 commit into from
Feb 11, 2023
Merged

Fix missing gpg sign and add correct maven deploy flow #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/build_deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,20 @@ jobs:
java-version: '8'
distribution: 'adopt'
cache: 'maven'
server-id: ossrh
server-username: MAVEN_USERNAME
server-password: MAVEN_PASSWORD
server-username: MAVEN_USERNAME # env variable for username in deploy
server-password: MAVEN_PASSWORD # env variable for token in deploy
gpg-private-key: ${{ secrets.MAVEN_GPG_PRIVATE_KEY }} # Value of the GPG private key to import
gpg-passphrase: MAVEN_GPG_PASSPHRASE # env variable for GPG private key passphrase
- name: Publish package
run: mvn -B deploy -DskipTests
run: |
./mvnw -B verify nexus-staging:deploy -P deploy && \
./mvnw -B nexus-staging:release -P deploy
env:
OPENSOURCE_PROJECTS_KS_PW: ${{ secrets.KEYSTORE_PASSWORD }}
OPENSOURCE_PROJECTS_KEY_PW: ${{ secrets.KEYSTORE_KEY_PASSWORD }}
MAVEN_USERNAME: ${{ secrets.OSSRH_USERNAME }}
MAVEN_PASSWORD: ${{ secrets.OSSRH_TOKEN }}
MAVEN_GPG_PASSPHRASE: ${{ secrets.MAVEN_GPG_PASSPHRASE }}
- name: Create and upload Github Release
uses: xresloader/upload-to-github-release@v1
env:
Expand Down
41 changes: 5 additions & 36 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>at.favre.lib</groupId>
<artifactId>common-parent</artifactId>
<version>15</version>
<version>18</version>
</parent>

<artifactId>bytes</artifactId>
Expand All @@ -26,27 +26,6 @@
<commonConfig.jarSign.skip>false</commonConfig.jarSign.skip>
</properties>

<repositories>
<repository>
<id>central</id>
<name>Maven Central</name>
<url>https://repo1.maven.org/maven2</url>
<snapshots>
<enabled>false</enabled>
</snapshots>
</repository>
</repositories>

<pluginRepositories>
<pluginRepository>
<id>central</id>
<name>Maven Central</name>
<url>https://repo1.maven.org/maven2</url>
<snapshots>
<enabled>false</enabled>
</snapshots>
</pluginRepository>
</pluginRepositories>
<build>
<plugins>
<plugin>
Expand Down Expand Up @@ -116,7 +95,6 @@
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.2</version>
<scope>test</scope>
</dependency>
<dependency>
Expand All @@ -133,18 +111,9 @@
</dependency>
</dependencies>

<distributionManagement>
<repository>
<id>ossrh</id>
<name>Central Repository OSSRH</name>
<url>https://oss.sonatype.org/service/local/staging/deploy/maven2/</url>
</repository>
</distributionManagement>

<scm>
<connection>https://github.com/patrickfav/bytes-java.git</connection>
<developerConnection>https://github.com/patrickfav/bytes-java.git</developerConnection>
<tag>HEAD</tag>
<connection>scm:git:https://github.com/patrickfav/bytes-java.git</connection>
<developerConnection>scm:git:https://github.com/patrickfav/bytes-java.git</developerConnection>
<url>https://github.com/patrickfav/bytes-java</url>
</scm>

Expand All @@ -154,7 +123,7 @@
</issueManagement>

<ciManagement>
<system>Travis</system>
<url>https://travis-ci.com/patrickfav/bytes-java</url>
<system>Github Actions</system>
<url>https://github.com/patrickfav/bytes-java/actions</url>
</ciManagement>
</project>