Fixes several bugs. Fixes #7. Improve codebase for maintainability.

[patrickdappollonio]

No description provided.

[Copilot]

Pull Request Overview

This PR fixes several bugs and enhances maintainability across the codebase by refactoring template compilation, improving GitHub asset handling, optimizing license lookups, and modularizing application logic.

• Refactored template initialization to package init, added download deduplication by architecture.
• Replaced linear license validation with an O(1) map lookup and strengthened error handling in GitHub HTTP helpers.
• Modularized main app flow (config parsing, filtering, formula/README generation) and improved utility functions.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tapgen/template/template.go	Removed sync.Once setup, moved template compilation to init, added deduplicateDownloadsByArchitecture
tapgen/template/functions.go	Extracted inline template helpers into named functions, introduced normalizeForTemplate bridge
tapgen/licenses/licenses.go	Replaced slice scan in Valid with prebuilt map for constant-time lookups
tapgen/github/downloads.go	Generalized JSON fetch to generics, factored asset filtering and SHA computation
tapgen/cfg/cfg.go	Split parsing and validation, renamed normalization helper, strengthened error messages
tapgen/app.go	Broke out filterConfigs, generateFormulas, generateReadme, unified error prefixes
Multiple test files	Added or extended tests across licenses, cfg, app

Comments suppressed due to low confidence (4)

tapgen/template/template.go:42

• [nitpick] The new deduplicateDownloadsByArchitecture function isn’t covered by any tests. Consider adding unit tests to verify correct selection logic for MUSL vs LIBC and different architectures.

func deduplicateDownloadsByArchitecture(downloads []github.Download) []github.Download {

tapgen/template/template.go:10

• The template package references github.Download but doesn’t import the GitHub package. Add import "github.com/patrickdappollonio/homebrew-tap/tapgen/github" to resolve this.

	"github.com/patrickdappollonio/homebrew-tap/tapgen/cfg"

tapgen/template/functions.go:4

• The functions.go file uses fmt and strings package functions (e.g., fmt.Sprintf, strings.ToLower) but doesn’t import "fmt" or "strings", causing compilation errors. Add the missing imports.

import (

tapgen/github/downloads.go:4

• This file uses strings.ToLower, bytes.Buffer, context.Context and time.Duration but doesn’t import "strings", "bytes", "context" or "time". Add the missing imports to fix compilation.

import (