optimize variable in MarkAreaView.ts

patelanuj28 · Apr 15, 2022 · cc3f4a7 · cc3f4a7
1 parent d3366c9
commit cc3f4a7
Showing 1 changed file with 13 additions and 21 deletions.
diff --git a/src/component/marker/MarkAreaView.ts b/src/component/marker/MarkAreaView.ts
@@ -109,6 +109,16 @@ function ifMarkAreaHasOnlyDim(
 function markAreaFilter(coordSys: CoordinateSystem, item: MarkAreaMergedItemOption) {
     const fromCoord = item.coord[0];
     const toCoord = item.coord[1];
+    const item0 = {
+        coord: fromCoord,
+        x: item.x0,
+        y: item.y0
+    };
+    const item1 = {
+        coord: toCoord,
+        x: item.x1,
+        y: item.y1
+    };
     if (isCoordinateSystemType<Cartesian2D>(coordSys, 'cartesian2d')) {
         // In case
         // {
@@ -128,28 +138,10 @@ function markAreaFilter(coordSys: CoordinateSystem, item: MarkAreaMergedItemOpti
         //when it's not included in coordinate system.
         //But filtering ahead can avoid keeping rendering markArea
         //when there are too many of them.
-        return markerHelper.zoneFilter(coordSys, {
-            coord: fromCoord,
-            x: item.x0,
-            y: item.y0
-        },
-        {
-            coord: toCoord,
-            x: item.x1,
-            y: item.y1
-        }
-        );
+        return markerHelper.zoneFilter(coordSys, item0, item1);
     }
-    return markerHelper.dataFilter(coordSys, {
-            coord: fromCoord,
-            x: item.x0,
-            y: item.y0
-        })
-        || markerHelper.dataFilter(coordSys, {
-            coord: toCoord,
-            x: item.x1,
-            y: item.y1
-        });
+    return markerHelper.dataFilter(coordSys, item0)
+        || markerHelper.dataFilter(coordSys, item1);
 }
 
 // dims can be ['x0', 'y0'], ['x1', 'y1'], ['x0', 'y1'], ['x1', 'y0']