-
Notifications
You must be signed in to change notification settings - Fork 100
Created a new patchflow that can generate unit tests #998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
plon-Susk7
commented
Nov 2, 2024
- In order to generate unit tests, the config file needs to have path where the class is located.
- We are using pytest as our framework and the same is passed to our prompt.
…lows/GenerateUnitTests/README.md
|
Here's an example of PR |
CTY-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use ExtractModelResponse step to handle extra texts from the LLM.
hi @CTY-git , the issues were resolved by your suggestions. I have added extra params to yml file and also mentioned it in README. Let me know if it's enough else I'll try to make changes to ExtractModelResponse. |
CTY-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a CI test case to generate unit tests on the files in tests/cicd/generate_docstring?
Where should I write this test case? |
|
@plon-Susk7 I am refering to adding a test on github action like this particular step: |
CTY-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks @CTY-git. Really sorry for naive mistakes that I overlooked. |